Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Issue 2059823002: Use correct value for Oscillator.frequency.minValue (Closed)

Created:
4 years, 6 months ago by Raymond Toy
Modified:
4 years, 6 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, hongchan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct value for Oscillator.frequency.minValue The minimum value for the Oscillator.frequency parameter is -Nyquist, not 0. See issue: https://github.com/WebAudio/web-audio-api/issues/813 Resolved in: https://github.com/WebAudio/web-audio-api/pull/838 BUG=619059 TEST=osc-negative-freq.html, updated audioparam-nominal-range.html Committed: https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f Cr-Commit-Position: refs/heads/master@{#399965}

Patch Set 1 #

Patch Set 2 : Add test for negative frequencies. #

Patch Set 3 : Update results for Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/osc-custom-sweep-snr-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/osc-negative-freq.html View 1 2 1 chunk +198 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/osc-negative-freq-expected.txt View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/osc-sawtooth-sweep-snr-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/osc-sine-sweep-snr-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/osc-square-sweep-snr-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/osc-triangle-sweep-snr-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/periodicwave-contexts-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
Raymond Toy
PTAL. The osc-* and periodic-wave tests needed to be updated because the warning message include ...
4 years, 6 months ago (2016-06-10 16:36:19 UTC) #2
hongchan
lgtm
4 years, 6 months ago (2016-06-10 16:44:43 UTC) #3
Raymond Toy
On 2016/06/10 16:36:19, Raymond Toy wrote: > PTAL. > > The osc-* and periodic-wave tests ...
4 years, 6 months ago (2016-06-10 16:53:23 UTC) #4
Raymond Toy
PTAL at the new osc-negative-freq test.
4 years, 6 months ago (2016-06-10 17:56:32 UTC) #5
Raymond Toy
On 2016/06/10 17:56:32, Raymond Toy wrote: > PTAL at the new osc-negative-freq test. Ping
4 years, 6 months ago (2016-06-14 16:12:38 UTC) #7
Raymond Toy
On 2016/06/14 16:12:38, Raymond Toy wrote: > On 2016/06/10 17:56:32, Raymond Toy wrote: > > ...
4 years, 6 months ago (2016-06-15 15:13:24 UTC) #8
hongchan
2nd lgtm.
4 years, 6 months ago (2016-06-15 16:47:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059823002/40001
4 years, 6 months ago (2016-06-15 17:05:52 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-15 18:30:56 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 18:31:05 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 18:32:45 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a5221add5997d445349f6eb3f5b88dc99a79af3f
Cr-Commit-Position: refs/heads/master@{#399965}

Powered by Google App Engine
This is Rietveld 408576698