Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2059803002: Fix GN bootstrap. (Closed)

Created:
4 years, 6 months ago by saiarcot895
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN bootstrap. Add two files needed to compile GN. R=brettw@chromium.org BUG= Committed: https://crrev.com/6810e5b4eb8470827156f0ee2041030c09fa9b04 Cr-Commit-Position: refs/heads/master@{#399288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
saiarcot895
4 years, 6 months ago (2016-06-10 15:29:49 UTC) #1
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-10 20:40:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059803002/1
4 years, 6 months ago (2016-06-10 21:23:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 22:06:33 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 22:06:49 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 22:07:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6810e5b4eb8470827156f0ee2041030c09fa9b04
Cr-Commit-Position: refs/heads/master@{#399288}

Powered by Google App Engine
This is Rietveld 408576698