Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Issue 20598006: Stop looking up custom filter program during style application. (Closed)

Created:
7 years, 4 months ago by dglazkov
Modified:
7 years, 4 months ago
Reviewers:
achicu, EthanM, eae, eseidel
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears, eae, eseidel, esprehn, Max Vujovic (mvujovic), krit
Visibility:
Public.

Description

Stop looking up custom filter program during style application. Since StyleResourceLoader::loadPendingShaders will reconcile a newly-created program vs. cached program anyway, there is no need for us to look up the program when applying CSS properties. BUG=259085 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155361

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M Source/core/css/resolver/FilterOperationResolver.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 4 chunks +10 lines, -16 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dglazkov
Ethan, adding you to make sure I am not crazy. I walked through the code, ...
7 years, 4 months ago (2013-08-01 18:42:23 UTC) #1
eseidel
I'm not sure ethan is our best contact here, but I suspect he or max ...
7 years, 4 months ago (2013-08-01 19:29:56 UTC) #2
eseidel
The patch looks reasonable, I assume all the tests still pass?
7 years, 4 months ago (2013-08-01 19:30:22 UTC) #3
dglazkov
On 2013/08/01 19:30:22, eseidel wrote: > The patch looks reasonable, I assume all the tests ...
7 years, 4 months ago (2013-08-01 19:31:12 UTC) #4
krit_webkit.org
Yes, Alex, Max and me will take a look at the patch. Thanks a lot ...
7 years, 4 months ago (2013-08-01 19:32:15 UTC) #5
eseidel
lgtm lgtm. Our Adobe friends will let us know if we've done wrong here.
7 years, 4 months ago (2013-08-01 19:32:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/20598006/1
7 years, 4 months ago (2013-08-01 19:32:34 UTC) #7
eseidel
Thanks. Feel encouraged to uncheck the CQ box if you feel it's premature.
7 years, 4 months ago (2013-08-01 19:35:01 UTC) #8
achicu
On 2013/08/01 19:35:01, eseidel wrote: > Thanks. Feel encouraged to uncheck the CQ box if ...
7 years, 4 months ago (2013-08-01 20:21:13 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-01 22:12:41 UTC) #10
Message was sent while issue was closed.
Change committed as 155361

Powered by Google App Engine
This is Rietveld 408576698