Make RenderedPosition constructor to work on flat tree

Make flat tree version RenderedPosition constructor to work on flat tree

This patch makes flat tree version of |RenderedPosition| constructor to work
on flat tree rather than DOM tree to calculate inline box position for
flat tree position correctly.

Before this patch, flat tree version of |RenderedPosition| constructor uses
|toPositionInDOMTree()|, but id doesn't work well for children of shadow
root and insertion point, e.g. CONENT elements and SLOT elements.

In attached layout test, |RenderedPosition| constructor attempts to compute
for CONTENT element in DETAIL element.

BUG=616070, 618421
TEST=LayoutTests/editing/selection/select_all/select_all_details_crash.html

Committed: https://crrev.com/874ac2203bcbf8d00ccb7c447ad2d307cb3dd7ce
Cr-Commit-Position: refs/heads/master@{#399150}

[yosin_UTC9, 2016-06-10 07:00:59]

Description was changed from

==========
2016-06-10T15:56:25

BUG=
==========

to

==========
Make flat tree version RenderedPosition constructor to work on flat tree

This patch makes flat tree version of |RenderedPosition| constructor to work
on flat tree rather than DOM tree to calculate inline box position for
flat tree position correctly.

BUG=616070, 618421
TEST=LayoutTests/editing/selection/select_all/select_all_details_crash.html
==========

[yosin_UTC9, 2016-06-10 08:01:17]

Description was changed from

==========
Make flat tree version RenderedPosition constructor to work on flat tree

This patch makes flat tree version of |RenderedPosition| constructor to work
on flat tree rather than DOM tree to calculate inline box position for
flat tree position correctly.

BUG=616070, 618421
TEST=LayoutTests/editing/selection/select_all/select_all_details_crash.html
==========

to

==========
Make flat tree version RenderedPosition constructor to work on flat tree

This patch makes flat tree version of |RenderedPosition| constructor to work
on flat tree rather than DOM tree to calculate inline box position for
flat tree position correctly.

Before this patch, flat tree version of |RenderedPosition| constructor uses
|toPositionInDOMTree()|, but id doesn't work well for children of shadow
root and insertion point, e.g. CONENT elements and SLOT elements.

In attached layout test, |RenderedPosition| constructor attempts to compute
for CONTENT element in DETAIL element.

BUG=616070, 618421
TEST=LayoutTests/editing/selection/select_all/select_all_details_crash.html
==========

[yosin_UTC9, 2016-06-10 08:01:17]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-06-10 08:01:25]

PTAL

[tkent, 2016-06-10 08:20:42]

lgtm

https://codereview.chromium.org/2059663002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_details_crash.html
(right):

https://codereview.chromium.org/2059663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_details_crash.html:5:
<div id="log">
nit: You may want to add '</div>', or remove this line.

[yosin_UTC9, 2016-06-10 09:18:01]

Thanks for reviewing!

Committing...

https://codereview.chromium.org/2059663002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_details_crash.html
(right):

https://codereview.chromium.org/2059663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_details_crash.html:5:
<div id="log">
On 2016/06/10 at 08:20:42, tkent wrote:
> nit: You may want to add '</div>', or remove this line.

Done.
When I remove <div id="log"></div>, I got error: Cannot read property
'appendChild' of null

[yosin_UTC9, 2016-06-10 09:18:04]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-06-10 09:18:04]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2059663002/#ps40001
(title: "2016-06-10T18:14:53 Update for review comments")

[commit-bot: I haz the power, 2016-06-10 09:18:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2059663002/40001

[commit-bot: I haz the power, 2016-06-10 10:38:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-10 10:40:08]

Description was changed from

==========
Make flat tree version RenderedPosition constructor to work on flat tree

This patch makes flat tree version of |RenderedPosition| constructor to work
on flat tree rather than DOM tree to calculate inline box position for
flat tree position correctly.

Before this patch, flat tree version of |RenderedPosition| constructor uses
|toPositionInDOMTree()|, but id doesn't work well for children of shadow
root and insertion point, e.g. CONENT elements and SLOT elements.

In attached layout test, |RenderedPosition| constructor attempts to compute
for CONTENT element in DETAIL element.

BUG=616070, 618421
TEST=LayoutTests/editing/selection/select_all/select_all_details_crash.html
==========

to

==========
Make flat tree version RenderedPosition constructor to work on flat tree

This patch makes flat tree version of |RenderedPosition| constructor to work
on flat tree rather than DOM tree to calculate inline box position for
flat tree position correctly.

Before this patch, flat tree version of |RenderedPosition| constructor uses
|toPositionInDOMTree()|, but id doesn't work well for children of shadow
root and insertion point, e.g. CONENT elements and SLOT elements.

In attached layout test, |RenderedPosition| constructor attempts to compute
for CONTENT element in DETAIL element.

BUG=616070, 618421
TEST=LayoutTests/editing/selection/select_all/select_all_details_crash.html

Committed: https://crrev.com/874ac2203bcbf8d00ccb7c447ad2d307cb3dd7ce
Cr-Commit-Position: refs/heads/master@{#399150}
==========

[commit-bot: I haz the power, 2016-06-10 10:40:09]

Patchset 3 (id:??) landed as
https://crrev.com/874ac2203bcbf8d00ccb7c447ad2d307cb3dd7ce
Cr-Commit-Position: refs/heads/master@{#399150}