Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2059653002: [turbofan] Introduce PlainPrimitiveToNumber. (Closed)

Created:
4 years, 6 months ago by Jarin
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce PlainPrimitiveToNumber. This should solve the problem with missing checkpoints after JSToNumber (PlainPrimitiveToNumber is marked no-write, so the frame-state propagation should see through it.) Unfortunately, this also duplicates the word32- and float64-truncation magic that we have for JSToNumber in "simplified lowering". Committed: https://crrev.com/2890137bdc421d1033a23827026ece89a54e7218 Cr-Commit-Position: refs/heads/master@{#36881}

Patch Set 1 #

Patch Set 2 : Tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -22 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 3 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 4 chunks +142 lines, -1 line 0 comments Download
M src/compiler/js-graph.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +5 lines, -18 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 6 months ago (2016-06-10 07:06:28 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-10 07:30:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059653002/20001
4 years, 6 months ago (2016-06-10 07:30:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 07:41:53 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 07:45:31 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2890137bdc421d1033a23827026ece89a54e7218
Cr-Commit-Position: refs/heads/master@{#36881}

Powered by Google App Engine
This is Rietveld 408576698