Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2059553002: [Android] Add support for standalone PDFium gn build on Android. (Closed)

Created:
4 years, 6 months ago by jbudorick
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

[Android] Add support for standalone PDFium gn build on Android. This pulls in the android NDK and catapult, rolls chromium/src/build/, and pulls in two .gni updates. It also fixes a few miscellaneous compile failures in android-specific code. BUG=pdfium:38 Committed: https://pdfium.googlesource.com/pdfium/+/7f3a15f714c8311b1adb7bdce1ac83c7113af598

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -34 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
M DEPS View 2 chunks +9 lines, -1 line 0 comments Download
M build_overrides/build.gni View 1 chunk +16 lines, -2 lines 0 comments Download
M core/fxge/android/fpf_skiafontmgr.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/android/fpf_skiafontmgr.cpp View 6 chunks +8 lines, -9 lines 0 comments Download
M core/fxge/android/fpf_skiamodule.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/android/fx_android_font.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/android/fx_android_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M testing/test.gni View 11 chunks +160 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jbudorick
built with: - gcc+arm - gcc+arm64 - clang+arm Both pdfium_unittests and pdfium_embeddertests build and run ...
4 years, 6 months ago (2016-06-10 01:21:14 UTC) #3
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-10 03:58:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059553002/40001
4 years, 6 months ago (2016-06-10 13:14:06 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 13:28:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/7f3a15f714c8311b1adb7bdce1ac83c7113a...

Powered by Google App Engine
This is Rietveld 408576698