Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: extensions/shell/browser/shell_app_delegate.cc

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/shell/browser/shell_app_delegate.h" 5 #include "extensions/shell/browser/shell_app_delegate.h"
6 6
7 #include "content/public/browser/web_contents.h" 7 #include "content/public/browser/web_contents.h"
8 #include "extensions/common/constants.h" 8 #include "extensions/common/constants.h"
9 #include "extensions/shell/browser/media_capture_util.h" 9 #include "extensions/shell/browser/media_capture_util.h"
10 #include "extensions/shell/browser/shell_extension_web_contents_observer.h" 10 #include "extensions/shell/browser/shell_extension_web_contents_observer.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 } 51 }
52 52
53 content::ColorChooser* ShellAppDelegate::ShowColorChooser( 53 content::ColorChooser* ShellAppDelegate::ShowColorChooser(
54 content::WebContents* web_contents, 54 content::WebContents* web_contents,
55 SkColor initial_color) { 55 SkColor initial_color) {
56 NOTIMPLEMENTED(); 56 NOTIMPLEMENTED();
57 return NULL; 57 return NULL;
58 } 58 }
59 59
60 void ShellAppDelegate::RunFileChooser( 60 void ShellAppDelegate::RunFileChooser(
61 content::WebContents* tab, 61 content::RenderFrameHost* render_frame_host,
62 const content::FileChooserParams& params) { 62 const content::FileChooserParams& params) {
63 NOTIMPLEMENTED(); 63 NOTIMPLEMENTED();
64 } 64 }
65 65
66 void ShellAppDelegate::RequestMediaAccessPermission( 66 void ShellAppDelegate::RequestMediaAccessPermission(
67 content::WebContents* web_contents, 67 content::WebContents* web_contents,
68 const content::MediaStreamRequest& request, 68 const content::MediaStreamRequest& request,
69 const content::MediaResponseCallback& callback, 69 const content::MediaResponseCallback& callback,
70 const extensions::Extension* extension) { 70 const extensions::Extension* extension) {
71 media_capture_util::GrantMediaStreamRequest( 71 media_capture_util::GrantMediaStreamRequest(
(...skipping 23 matching lines...) Expand all
95 content::WebContents* web_contents) { 95 content::WebContents* web_contents) {
96 return true; 96 return true;
97 } 97 }
98 98
99 void ShellAppDelegate::SetTerminatingCallback(const base::Closure& callback) { 99 void ShellAppDelegate::SetTerminatingCallback(const base::Closure& callback) {
100 // TODO(jamescook): Should app_shell continue to close the app window 100 // TODO(jamescook): Should app_shell continue to close the app window
101 // manually or should it use a browser termination callback like Chrome? 101 // manually or should it use a browser termination callback like Chrome?
102 } 102 }
103 103
104 } // namespace extensions 104 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698