Issue 205953002: Revert of Remove WebInspector.HeapSnapshotArraySlice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 205953002: Revert of Remove WebInspector.HeapSnapshotArraySlice (Closed)

Created:
6 years, 9 months ago by esprehn

Modified:
6 years, 9 months ago

Reviewers:
alph, yurys, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert of Remove WebInspector.HeapSnapshotArraySlice (https://codereview.chromium.org/204563002/) Reason for revert: Made tests start failing http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html,inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html Original issue's description: > Remove WebInspector.HeapSnapshotArraySlice > > Uin32Array already has subarray method that returns a new view for the same array buffer. > > BUG=None > R=alph@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169554 TBR=alph@chromium.org,loislo@chromium.org,yurys@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169599

Patch Set 1 #

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -42 lines)			Patch
M	LayoutTests/inspector/profiler/heap-snapshot.html	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	LayoutTests/inspector/profiler/heap-snapshot-test.js	View	2 chunks	+5 lines, -11 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshot.js	View	10 chunks	+56 lines, -17 lines	0 comments	Download
M	Source/devtools/front_end/JSHeapSnapshot.js	View	5 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

esprehn

Created Revert of Remove WebInspector.HeapSnapshotArraySlice

6 years, 9 months ago (2014-03-20 03:25:36 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/205953002/1

6 years, 9 months ago (2014-03-20 03:25:44 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages