Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2059513003: Add a policy for disabling the stripping of PAC URLs. (Closed)

Created:
4 years, 6 months ago by eroman
Modified:
4 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Add a policy for disabling the stripping of PAC URLs. The default is to strip https:// URLs before submitting them to PAC scripts. This CL introduces the policy "PacHttpsUrlStrippingEnabled" for disabling this security feature. Setting the policy to "false" causes Chrome to no longer strip https:// URLs before sending them to PAC scripts. This applies to all profiles, and all PAC scripts (including those discovered through WPAD, and those delivered over an insecure transport). The intent of this policy is to help enterprises with a compatibility problem transition. BUG=616396 TBR=isherman@chromium.org Review-Url: https://codereview.chromium.org/2030193004 Cr-Commit-Position: refs/heads/master@{#397808} (cherry picked from commit 9f7ea64cf573101c01ddcf020b87c63089038834) Committed: https://chromium.googlesource.com/chromium/src/+/4874cac8cee7b9735893e678758a53dcede20700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -15 lines) Patch
M chrome/browser/io_thread.h View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 4 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/net/proxy_service_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +43 lines, -0 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +10 lines, -0 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 chunk +19 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
eroman
4 years, 6 months ago (2016-06-10 08:01:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4874cac8cee7b9735893e678758a53dcede20700 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698