Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2059503002: Fix more flakiness in pkg tests. (Closed)

Created:
4 years, 6 months ago by Florian Schneider
Modified:
4 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix more flakiness in pkg tests. I already fixed similar failures. I recommend eliminating all uses of pumpEventQueue. BUG=#26556 R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/705e9e781dcd8474ecd7b0d5e946eb38f55bdd7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pkg/analysis_server/test/analysis_server_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
4 years, 6 months ago (2016-06-09 21:59:50 UTC) #1
scheglov
LGTM
4 years, 6 months ago (2016-06-09 22:07:12 UTC) #2
Florian Schneider
4 years, 6 months ago (2016-06-09 22:08:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
705e9e781dcd8474ecd7b0d5e946eb38f55bdd7f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698