Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2059463003: Flip win_chromium_rel_ng to GN, remove win8_chromium_ng from the CQ. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, jam, brucedawson, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip win_chromium_rel_ng to GN, remove win8_chromium_ng from the CQ. This commit reverts r398210 and re-lands r397982 (more or less). R=brettw@chromium.org BUG=617837 Committed: https://crrev.com/21742f893ef0a3074ba1cf113b5c0e6c42bf0f7e Cr-Commit-Position: refs/heads/master@{#399772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -596 lines) Patch
M infra/config/cq.cfg View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.win.json View 7 chunks +72 lines, -585 lines 0 comments Download
M tools/mb/mb_config.pyl View 4 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
Assuming https://codereview.chromium.org/2043873004/ lands and sticks, we should flip the CQ bots again to get some ...
4 years, 6 months ago (2016-06-09 21:44:25 UTC) #1
brettw
lgtm
4 years, 6 months ago (2016-06-09 22:00:19 UTC) #2
Dirk Pranke
let's try again and see what happens, cycle-time-wise ...
4 years, 6 months ago (2016-06-14 17:50:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059463003/1
4 years, 6 months ago (2016-06-14 17:50:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 20:16:18 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 20:18:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21742f893ef0a3074ba1cf113b5c0e6c42bf0f7e
Cr-Commit-Position: refs/heads/master@{#399772}

Powered by Google App Engine
This is Rietveld 408576698