third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp - Issue 2059433002: Use transform paint property nodes in SVG [spv2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp

Issue 2059433002: Use transform paint property nodes in SVG [spv2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svgTransformProps2

Patch Set: Post-blinkon rebase, add some dchecks, add some fixmes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp ('k') | third_party/WebKit/Source/core/paint/SVGImagePainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp b/third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp

index a051b194721f13a28cd41a42933bd1e6031958e3..f7f61ea6f421b2fce1b9ab79dc40176a6c008f67 100644

--- a/third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp

@@ -11,7 +11,6 @@

#include "core/paint/ObjectPainter.h"

#include "core/paint/PaintInfo.h"

#include "core/paint/SVGPaintContext.h"

-#include "core/paint/TransformRecorder.h"

#include "wtf/Optional.h"

namespace blink {

@@ -42,7 +41,7 @@ void SVGForeignObjectPainter::paint(const PaintInfo& paintInfo)

PaintInfo paintInfoBeforeFiltering(paintInfo);

paintInfoBeforeFiltering.updateCullRect(m_layoutSVGForeignObject.localSVGTransform());

- TransformRecorder transformRecorder(paintInfoBeforeFiltering.context, m_layoutSVGForeignObject, m_layoutSVGForeignObject.localSVGTransform());

+ SVGTransformContext transformContext(paintInfoBeforeFiltering.context, m_layoutSVGForeignObject, m_layoutSVGForeignObject.localSVGTransform());

Optional<FloatClipRecorder> clipRecorder;

if (SVGLayoutSupport::isOverflowHidden(&m_layoutSVGForeignObject))