Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 205943003: Remove unnecessary [NoInterfaceObject] from testing IDL files (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove unnecessary [NoInterfaceObject] from testing IDL files Testing IDL files no longer need [NoInterfaceObject], as we now don't feed them into the list of main interface files ('main_interface_idl_files' in generated_bindings.gyp); previously it was necessary because we didn't distinguish these files. This removes the extended attribute, simplifying them. TBR=haraken BUG=341748 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M Source/build/scripts/templates/InternalRuntimeFlags.idl.tmpl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/build/scripts/templates/InternalSettingsGenerated.idl.tmpl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/GCObservation.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/InternalProfilers.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/testing/LayerRect.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/LayerRectList.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/MallocStatistics.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/TypeConversions.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Nils Barth (inactive)
De-crufting.
6 years, 9 months ago (2014-03-20 03:22:25 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-20 03:22:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/205943003/1
6 years, 9 months ago (2014-03-20 03:22:33 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 03:25:06 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-20 03:25:07 UTC) #5
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-20 03:31:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/205943003/1
6 years, 9 months ago (2014-03-20 03:31:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 04:28:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 04:28:52 UTC) #9
haraken
LGTM
6 years, 9 months ago (2014-03-20 04:32:03 UTC) #10
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-20 05:46:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/205943003/1
6 years, 9 months ago (2014-03-20 05:46:28 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 06:50:41 UTC) #13
Message was sent while issue was closed.
Change committed as 169629

Powered by Google App Engine
This is Rietveld 408576698