Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2059403003: [turbofan] Stage binop type feedback. (Closed)

Created:
4 years, 6 months ago by Jarin
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich, Benedikt Meurer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Stage binop type feedback. Committed: https://crrev.com/a5dd1c4631d126ee7c91371c54b738841ca6c4f2 Cr-Commit-Position: refs/heads/master@{#36999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Jarin
Could you rubber-stamp this, please?
4 years, 6 months ago (2016-06-14 13:36:51 UTC) #2
mvstanton
Uncomfortably excitable LGTM.
4 years, 6 months ago (2016-06-14 13:38:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059403003/1
4 years, 6 months ago (2016-06-14 13:41:52 UTC) #5
Benedikt Meurer
Why not landing?
4 years, 6 months ago (2016-06-15 03:38:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059403003/1
4 years, 6 months ago (2016-06-15 06:56:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 06:58:43 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 06:58:45 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/28fbec405548c43088cade1cd17d8407ca948a21 Cr-Commit-Position: refs/heads/master@{#36988}
4 years, 6 months ago (2016-06-15 06:59:00 UTC) #14
Jarin
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2066193002/ by jarin@chromium.org. ...
4 years, 6 months ago (2016-06-15 07:22:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059403003/1
4 years, 6 months ago (2016-06-15 12:11:42 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 12:13:04 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 12:14:16 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5dd1c4631d126ee7c91371c54b738841ca6c4f2
Cr-Commit-Position: refs/heads/master@{#36999}

Powered by Google App Engine
This is Rietveld 408576698