chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h - Issue 2059363004: Gracefully handle extremely small windows in tab-modal sign in flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h

Issue 2059363004: Gracefully handle extremely small windows in tab-modal sign in flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change auto to int. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/profiles/profile_chooser_view.cc ('k') | chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h

diff --git a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h

index 277cf77552021bb42d5720d1fd3868bb1f5b40dd..70c9665d65aa1f44f311ea41c8a88deafa203cf1 100644

--- a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h

+++ b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h

@@ -47,10 +47,10 @@ class SigninViewControllerDelegateViews : public views::DialogDelegateView,

static views::WebView* CreateGaiaWebView(

content::WebContentsDelegate* delegate,

profiles::BubbleViewMode mode,

- Profile* profile,

+ Browser* browser,

signin_metrics::AccessPoint access_point);

- static views::WebView* CreateSyncConfirmationWebView(Profile* profile);

+ static views::WebView* CreateSyncConfirmationWebView(Browser* browser);

// views::DialogDelegateView:

views::View* GetContentsView() override;