Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2059343002: Fix typo in sandbox/linux/BUILD.gn. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in sandbox/linux/BUILD.gn. In r399050 I added a condition to fix component builds of the Linux sandbox to not contain -rpath=$ORIGIN, but I messed up the non-gold configuration. This patch fixes the typo. TBR=eugenis@chromium.org, llozano@chromium.org, mdempsky@chromium.org BUG=612647 Committed: https://crrev.com/41d05be20fcf850c7ae1a01ae08a3f339e8f4aab Cr-Commit-Position: refs/heads/master@{#399498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sandbox/linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
4 years, 6 months ago (2016-06-13 17:55:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059343002/1
4 years, 6 months ago (2016-06-13 17:56:14 UTC) #3
Evgeniy Stepanov
Thanks! LGTM
4 years, 6 months ago (2016-06-13 17:59:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 18:59:53 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 18:59:54 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 19:02:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41d05be20fcf850c7ae1a01ae08a3f339e8f4aab
Cr-Commit-Position: refs/heads/master@{#399498}

Powered by Google App Engine
This is Rietveld 408576698