Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2059263002: skiaserve no longer crashes when no X server is present (Closed)

Created:
4 years, 6 months ago by ethannicholas
Modified:
4 years, 6 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skiaserve no longer crashes when no X server is present GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2059263002 Committed: https://skia.googlesource.com/skia/+/2ec06c9b1c861d456b85ffe48b27e4dcae4800cb

Patch Set 1 #

Patch Set 2 : added support for MESA software rendering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M tools/skiaserve/Request.cpp View 1 2 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059263002/1
4 years, 6 months ago (2016-06-13 15:17:30 UTC) #3
ethannicholas
4 years, 6 months ago (2016-06-13 15:17:39 UTC) #5
jcgregorio
On 2016/06/13 at 15:17:39, ethannicholas wrote: > "skiaserve no longer crashes when no X server ...
4 years, 6 months ago (2016-06-13 15:30:18 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 15:30:59 UTC) #8
ethannicholas
4 years, 6 months ago (2016-06-13 17:06:05 UTC) #9
jcgregorio
On 2016/06/13 at 17:06:05, ethannicholas wrote: > LGTM Wow, that was less code than I ...
4 years, 6 months ago (2016-06-13 17:08:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059263002/20001
4 years, 6 months ago (2016-06-13 17:08:48 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 17:20:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2ec06c9b1c861d456b85ffe48b27e4dcae4800cb

Powered by Google App Engine
This is Rietveld 408576698