Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2059253003: Use trackCacheDependencies for performance speedup (Closed)

Created:
4 years, 6 months ago by Jennifer Messerly
Modified:
4 years, 6 months ago
Reviewers:
scheglov
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : revert sdk options #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M lib/src/analyzer/context.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M pubspec.lock View 4 chunks +5 lines, -5 lines 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
https://codereview.chromium.org/2059253003/diff/1/lib/src/analyzer/context.dart File lib/src/analyzer/context.dart (right): https://codereview.chromium.org/2059253003/diff/1/lib/src/analyzer/context.dart#newcode195 lib/src/analyzer/context.dart:195: ..trackCacheDependencies = false; Not sure if this matters for ...
4 years, 6 months ago (2016-06-13 18:21:11 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2059253003/diff/1/lib/src/analyzer/context.dart File lib/src/analyzer/context.dart (right): https://codereview.chromium.org/2059253003/diff/1/lib/src/analyzer/context.dart#newcode195 lib/src/analyzer/context.dart:195: ..trackCacheDependencies = false; On 2016/06/13 18:21:11, John Messerly ...
4 years, 6 months ago (2016-06-13 18:23:28 UTC) #3
Jennifer Messerly
Thanks! Since it shouldn't matter either way, I've reverted that change for SDK options.
4 years, 6 months ago (2016-06-13 18:26:39 UTC) #4
Jennifer Messerly
4 years, 6 months ago (2016-06-13 18:26:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a713bb23810d76b1d954b9942dd674212db84c7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698