Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2059253002: Revert of [Android] Ensure perf test runner does not create shards for blacklisted devices. (Closed)

Created:
4 years, 6 months ago by rnephew (Reviews Here)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Ensure perf test runner does not create shards for blacklisted devices. (patchset #4 id:60001 of https://codereview.chromium.org/2039363002/ ) Reason for revert: Possibly breaking v8 perf bots. Original issue's description: > [Android] Ensure perf test runner does not create shards for blacklisted devices. > > BUG=617559 > > Committed: https://crrev.com/15c70d1120b419bc68a484d8ecce5773433466f0 > Cr-Commit-Position: refs/heads/master@{#398197} TBR=jbudorick@chromium.org,perezju@chromium.org,mikecase@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=617559 Committed: https://crrev.com/c89b1748ad3fee34318dd63b32e881a7361743ce Cr-Commit-Position: refs/heads/master@{#399460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M build/android/pylib/base/test_dispatcher.py View 1 chunk +2 lines, -6 lines 0 comments Download
M build/android/pylib/perf/setup.py View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rnephew (Reviews Here)
Created Revert of [Android] Ensure perf test runner does not create shards for blacklisted devices.
4 years, 6 months ago (2016-06-13 15:02:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059253002/1
4 years, 6 months ago (2016-06-13 15:03:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 15:52:10 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 15:52:18 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c89b1748ad3fee34318dd63b32e881a7361743ce Cr-Commit-Position: refs/heads/master@{#399460}
4 years, 6 months ago (2016-06-13 15:54:07 UTC) #7
perezju
4 years, 6 months ago (2016-06-20 11:23:26 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2084493003/ by perezju@chromium.org.

The reason for reverting is: CL wasn't responsible for the v8 breakage.

Powered by Google App Engine
This is Rietveld 408576698