components/ntp_snippets/snippet_category.h - Issue 2059203002: Add ContentSuggestion, ContentSuggestionCategory and ContentSuggestionProviderType

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_snippets/snippet_category.h

Issue 2059203002: Add ContentSuggestion, ContentSuggestionCategory and ContentSuggestionProviderType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
	Marc Treib 2016/06/13 13:08:17 :) :) Philipp Keck 2016/06/13 14:13:14 Done. Show quoted text On 2016/06/13 13:08:17, Marc Treib wrote: > :) Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_NTP_SNIPPETS_SNIPPET_CATEGORY_TYPE_H_

	6 #define COMPONENTS_NTP_SNIPPETS_SNIPPET_CATEGORY_TYPE_H_

	7

	8 namespace ntp_snippets {

	9

	10 // The category of a snippet. Note that even though these categories currently

	11 // match the provider types, a provider type is not limited to provide snippets

	12 // of a single (fixed) category only. The category is used to determine where

	13 // and how to display the snippet.

	14 enum class SnippetCategory : int { ARTICLE, OFFLINE_PAGE, READING_LIST };
	Marc Treib 2016/06/13 13:08:17 Please remove the categories that don't exist yet. Please remove the categories that don't exist yet. Philipp Keck 2016/06/13 14:13:14 Done. Show quoted text On 2016/06/13 13:08:17, Marc Treib wrote: > Please remove the categories that don't exist yet. Done. Marc Treib 2016/06/13 15:11:10 OFFLINE_PAGE also doesn't exist yet. Show quoted text On 2016/06/13 14:13:14, pke wrote: > On 2016/06/13 13:08:17, Marc Treib wrote: > > Please remove the categories that don't exist yet. > > Done. OFFLINE_PAGE also doesn't exist yet. Marc Treib 2016/06/14 09:29:44 This isn't resolved yet; also for the ProviderType Show quoted text On 2016/06/13 15:11:10, Marc Treib wrote: > On 2016/06/13 14:13:14, pke wrote: > > On 2016/06/13 13:08:17, Marc Treib wrote: > > > Please remove the categories that don't exist yet. > > > > Done. > > OFFLINE_PAGE also doesn't exist yet. This isn't resolved yet; also for the ProviderType. Philipp Keck 2016/06/14 10:32:00 Done. Show quoted text On 2016/06/14 09:29:44, Marc Treib wrote: > On 2016/06/13 15:11:10, Marc Treib wrote: > > On 2016/06/13 14:13:14, pke wrote: > > > On 2016/06/13 13:08:17, Marc Treib wrote: > > > > Please remove the categories that don't exist yet. > > > > > > Done. > > > > OFFLINE_PAGE also doesn't exist yet. > > This isn't resolved yet; also for the ProviderType. Done.
	15

	16 } // namespace ntp_snippets

	17

	18 #endif // COMPONENTS_NTP_SNIPPETS_SNIPPET_CATEGORY_TYPE_H_

OLD	NEW