Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2059193002: [turbolizer] Features and bug-fixes (Closed)

Created:
4 years, 6 months ago by danno
Modified:
4 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbolizer] Features and bug-fixes Fix bugs and add a few small useful features: * Fix Schedule view to properly parse schedule output and respond to switching back to graph views. * Add shorcuts for showing edges of selected nodes. - 'i' shows all inputs - 'o' shows all outputs - '1'-'9' shows all nodes nth input where 1 <= n <= 9 - 'c' shows all control inputs - 'e' shows all effect inputs * Holding the control key down when using a edge-showing shortcut toggles edge state rather the just showing. * 'a' selects all nodes in graph view. * Node selection is preserved between graph views and Schedule views. * Holding control key down when using regular expression search shows currently hidden nodes that match the regex search. * Pane expansion buttons now respond to clicks in entire button area. * Default text in regex search box makes searching more discoverable. Committed: https://crrev.com/e52907f807dd64147deac064973325d2409ba144 Cr-Commit-Position: refs/heads/master@{#36932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -46 lines) Patch
M tools/turbolizer/graph-view.js View 8 chunks +148 lines, -27 lines 0 comments Download
M tools/turbolizer/schedule-view.js View 2 chunks +21 lines, -2 lines 0 comments Download
M tools/turbolizer/turbo-visualizer.css View 2 chunks +2 lines, -1 line 0 comments Download
M tools/turbolizer/turbo-visualizer.js View 3 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
danno
ptal (rubber stamp)
4 years, 6 months ago (2016-06-13 12:36:34 UTC) #3
Michael Starzinger
LGTM (rubber-stamp).
4 years, 6 months ago (2016-06-13 12:36:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059193002/1
4 years, 6 months ago (2016-06-13 12:52:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 13:21:29 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 13:22:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e52907f807dd64147deac064973325d2409ba144
Cr-Commit-Position: refs/heads/master@{#36932}

Powered by Google App Engine
This is Rietveld 408576698