Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: src/json-stringifier.cc

Issue 2059173002: Reland of place all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/json-parser.cc ('k') | src/log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/json-stringifier.cc
diff --git a/src/json-stringifier.cc b/src/json-stringifier.cc
index 51899a9c8bc765a4a7587416a4643ac19af0edab..7864844f1fcef0c6b160804be56702877e6b674e 100644
--- a/src/json-stringifier.cc
+++ b/src/json-stringifier.cc
@@ -274,7 +274,7 @@
Handle<Object> key) {
StackLimitCheck interrupt_check(isolate_);
if (interrupt_check.InterruptRequested() &&
- isolate_->stack_guard()->HandleInterrupts()->IsException()) {
+ isolate_->stack_guard()->HandleInterrupts()->IsException(isolate_)) {
return EXCEPTION;
}
if (object->IsJSReceiver()) {
@@ -360,7 +360,7 @@
} else if (class_name == isolate_->heap()->Boolean_string()) {
Object* value = JSValue::cast(*object)->value();
DCHECK(value->IsBoolean());
- builder_.AppendCString(value->IsTrue() ? "true" : "false");
+ builder_.AppendCString(value->IsTrue(isolate_) ? "true" : "false");
} else {
// ES6 24.3.2.1 step 10.c, serialize as an ordinary JSObject.
return SerializeJSObject(object);
@@ -407,7 +407,8 @@
StackLimitCheck interrupt_check(isolate_);
while (i < length) {
if (interrupt_check.InterruptRequested() &&
- isolate_->stack_guard()->HandleInterrupts()->IsException()) {
+ isolate_->stack_guard()->HandleInterrupts()->IsException(
+ isolate_)) {
return EXCEPTION;
}
Separator(i == 0);
@@ -424,7 +425,8 @@
StackLimitCheck interrupt_check(isolate_);
while (i < length) {
if (interrupt_check.InterruptRequested() &&
- isolate_->stack_guard()->HandleInterrupts()->IsException()) {
+ isolate_->stack_guard()->HandleInterrupts()->IsException(
+ isolate_)) {
return EXCEPTION;
}
Separator(i == 0);
« no previous file with comments | « src/json-parser.cc ('k') | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698