src/crankshaft/hydrogen-types.cc - Issue 2059173002: Reland of place all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen-types.cc

Issue 2059173002: Reland of place all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/hydrogen-types.cc

diff --git a/src/crankshaft/hydrogen-types.cc b/src/crankshaft/hydrogen-types.cc

index 773685b04c162daf927764815a2985c70a07b5f6..20d50d897c72de5981a57388f8024144792d8e56 100644

--- a/src/crankshaft/hydrogen-types.cc

+++ b/src/crankshaft/hydrogen-types.cc

@@ -38,7 +38,7 @@

if (raw_value->IsSmi()) return HType::Smi();

DCHECK(raw_value->IsHeapObject());

Isolate* isolate = HeapObject::cast(*value)->GetIsolate();

- if (raw_value->IsNull()) return HType::Null();

+ if (raw_value->IsNull(isolate)) return HType::Null();

if (raw_value->IsHeapNumber()) {

double n = Handle<v8::internal::HeapNumber>::cast(value)->value();

return IsSmiDouble(n) ? HType::Smi() : HType::HeapNumber();

« no previous file with comments | « src/crankshaft/hydrogen-instructions.cc ('k') | src/debug/debug.cc » ('j') | no next file with comments »