test/cctest/compiler/test-js-context-specialization.cc - Issue 2059173002: Reland of place all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-js-context-specialization.cc

Issue 2059173002: Reland of place all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/compiler/test-js-context-specialization.cc

diff --git a/test/cctest/compiler/test-js-context-specialization.cc b/test/cctest/compiler/test-js-context-specialization.cc

index 9c024f8816d24e4f10b0283f2d5a7f9086525594..e9bf0647509622523b3b3ca0b44e7dd505d2eaa8 100644

--- a/test/cctest/compiler/test-js-context-specialization.cc

+++ b/test/cctest/compiler/test-js-context-specialization.cc

@@ -225,10 +225,14 @@

FunctionTester T(

"(function() { if (false) { var x = 1; } function inc(a)"

" { return x; } return inc; })()"); // x is undefined!

- CHECK(T.Call(T.Val(0.0), T.Val(0.0)).ToHandleChecked()->IsUndefined());

- CHECK(T.Call(T.Val(2.0), T.Val(0.0)).ToHandleChecked()->IsUndefined());

- CHECK(T.Call(T.Val(-2.1), T.Val(0.0)).ToHandleChecked()->IsUndefined());

+ i::Isolate* isolate = CcTest::i_isolate();

+ CHECK(

+ T.Call(T.Val(0.0), T.Val(0.0)).ToHandleChecked()->IsUndefined(isolate));

+ CHECK(

+ T.Call(T.Val(2.0), T.Val(0.0)).ToHandleChecked()->IsUndefined(isolate));

+ CHECK(T.Call(T.Val(-2.1), T.Val(0.0))

+ .ToHandleChecked()

+ ->IsUndefined(isolate));

}

{

« no previous file with comments | « src/wasm/wasm-module.cc ('k') | test/cctest/heap/test-alloc.cc » ('j') | no next file with comments »