test/cctest/test-dictionary.cc - Issue 2059173002: Reland of place all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-dictionary.cc

Issue 2059173002: Reland of place all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-dictionary.cc

diff --git a/test/cctest/test-dictionary.cc b/test/cctest/test-dictionary.cc

index 584fa7c05974fd5646ff450060eb0c0f6f85d4b3..28adc7b4d34d60378213fa0e7124e40620561f0d 100644

--- a/test/cctest/test-dictionary.cc

+++ b/test/cctest/test-dictionary.cc

@@ -210,7 +210,7 @@

heap::SimulateFullSpace(CcTest::heap()->old_space());

// Calling Lookup() should not cause GC ever.

- CHECK(table->Lookup(key)->IsTheHole());

+ CHECK(table->Lookup(key)->IsTheHole(isolate));

// Calling Put() should request GC by returning a failure.

int gc_count = isolate->heap()->gc_count();

« no previous file with comments | « test/cctest/test-api.h ('k') | test/cctest/test-field-type-tracking.cc » ('j') | no next file with comments »