src/compiler/js-create-lowering.cc - Issue 2059173002: Reland of place all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-create-lowering.cc

Issue 2059173002: Reland of place all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/js-create-lowering.cc

diff --git a/src/compiler/js-create-lowering.cc b/src/compiler/js-create-lowering.cc

index f8ac78326022ab98d11f1bf1d8983ee6bcc853e2..275e44e8c4c0ba21755bbc9be93605356b243b66 100644

--- a/src/compiler/js-create-lowering.cc

+++ b/src/compiler/js-create-lowering.cc

@@ -965,7 +965,7 @@

graph()->NewNode(common()->FinishRegion(), value, effect);

} else if (property_details.representation().IsSmi()) {

// Ensure that value is stored as smi.

- value = boilerplate_value->IsUninitialized()

+ value = boilerplate_value->IsUninitialized(isolate())

? jsgraph()->ZeroConstant()

: jsgraph()->Constant(boilerplate_value);

} else {

« no previous file with comments | « src/compiler/js-call-reducer.cc ('k') | src/compiler/js-graph.cc » ('j') | no next file with comments »