src/string-stream.cc - Issue 2059173002: Reland of place all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string-stream.cc

Issue 2059173002: Reland of place all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/string-stream.cc

diff --git a/src/string-stream.cc b/src/string-stream.cc

index 6e61c372d1119c8eeea7f02f85b8cdc050df650b..86aaac5ce0d4e26979e318459cb3c8db26a551d7 100644

--- a/src/string-stream.cc

+++ b/src/string-stream.cc

@@ -527,7 +527,7 @@

Object* name = fun->shared()->name();

bool print_name = false;

Isolate* isolate = fun->GetIsolate();

- if (receiver->IsNull() || receiver->IsUndefined(isolate) ||

+ if (receiver->IsNull(isolate) || receiver->IsUndefined(isolate) ||

receiver->IsJSProxy()) {

print_name = true;

} else if (isolate->context() != nullptr) {

« no previous file with comments | « src/runtime/runtime-utils.h ('k') | src/wasm/wasm-module.cc » ('j') | no next file with comments »