src/debug/debug-frames.cc - Issue 2059173002: Reland of place all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-frames.cc

Issue 2059173002: Reland of place all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/debug-frames.cc

diff --git a/src/debug/debug-frames.cc b/src/debug/debug-frames.cc

index 5eeb42a9e281937cf1dd96bb3cf3eff6bdd4c750..b1a8af256934d3e5d8ba93c49a9bce0d7c5e8d62 100644

--- a/src/debug/debug-frames.cc

+++ b/src/debug/debug-frames.cc

@@ -138,7 +138,9 @@

if (value->IsTheHole(isolate_)) {

value = isolate_->factory()->undefined_value();

}

- if (value->IsOptimizedOut()) value = isolate_->factory()->undefined_value();

+ if (value->IsOptimizedOut(isolate_)) {

+ value = isolate_->factory()->undefined_value();

+ }

JSObject::SetOwnPropertyIgnoreAttributes(target, name, value, NONE).Check();

}

« no previous file with comments | « src/debug/debug.cc ('k') | src/elements.cc » ('j') | no next file with comments »