Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Side by Side Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 2059173002: Reland of place all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/futex-emulation.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 __ push(Immediate(lit)); 480 __ push(Immediate(lit));
481 } 481 }
482 } 482 }
483 483
484 484
485 void FullCodeGenerator::TestContext::Plug(Handle<Object> lit) const { 485 void FullCodeGenerator::TestContext::Plug(Handle<Object> lit) const {
486 codegen()->PrepareForBailoutBeforeSplit(condition(), 486 codegen()->PrepareForBailoutBeforeSplit(condition(),
487 true, 487 true,
488 true_label_, 488 true_label_,
489 false_label_); 489 false_label_);
490 DCHECK(lit->IsNull() || lit->IsUndefined(isolate()) || 490 DCHECK(lit->IsNull(isolate()) || lit->IsUndefined(isolate()) ||
491 !lit->IsUndetectable()); 491 !lit->IsUndetectable());
492 if (lit->IsUndefined(isolate()) || lit->IsNull() || lit->IsFalse()) { 492 if (lit->IsUndefined(isolate()) || lit->IsNull(isolate()) ||
493 lit->IsFalse(isolate())) {
493 if (false_label_ != fall_through_) __ jmp(false_label_); 494 if (false_label_ != fall_through_) __ jmp(false_label_);
494 } else if (lit->IsTrue() || lit->IsJSObject()) { 495 } else if (lit->IsTrue(isolate()) || lit->IsJSObject()) {
495 if (true_label_ != fall_through_) __ jmp(true_label_); 496 if (true_label_ != fall_through_) __ jmp(true_label_);
496 } else if (lit->IsString()) { 497 } else if (lit->IsString()) {
497 if (String::cast(*lit)->length() == 0) { 498 if (String::cast(*lit)->length() == 0) {
498 if (false_label_ != fall_through_) __ jmp(false_label_); 499 if (false_label_ != fall_through_) __ jmp(false_label_);
499 } else { 500 } else {
500 if (true_label_ != fall_through_) __ jmp(true_label_); 501 if (true_label_ != fall_through_) __ jmp(true_label_);
501 } 502 }
502 } else if (lit->IsSmi()) { 503 } else if (lit->IsSmi()) {
503 if (Smi::cast(*lit)->value() == 0) { 504 if (Smi::cast(*lit)->value() == 0) {
504 if (false_label_ != fall_through_) __ jmp(false_label_); 505 if (false_label_ != fall_through_) __ jmp(false_label_);
(...skipping 3204 matching lines...) Expand 10 before | Expand all | Expand 10 after
3709 isolate->builtins()->OnStackReplacement()->entry(), 3710 isolate->builtins()->OnStackReplacement()->entry(),
3710 Assembler::target_address_at(call_target_address, unoptimized_code)); 3711 Assembler::target_address_at(call_target_address, unoptimized_code));
3711 return ON_STACK_REPLACEMENT; 3712 return ON_STACK_REPLACEMENT;
3712 } 3713 }
3713 3714
3714 3715
3715 } // namespace internal 3716 } // namespace internal
3716 } // namespace v8 3717 } // namespace v8
3717 3718
3718 #endif // V8_TARGET_ARCH_X87 3719 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/futex-emulation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698