Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Side by Side Diff: src/execution.cc

Issue 2059173002: Reland of place all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/elements.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/execution.h" 5 #include "src/execution.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/isolate-inl.h" 9 #include "src/isolate-inl.h"
10 #include "src/messages.h" 10 #include "src/messages.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 argc, argv); 99 argc, argv);
100 } 100 }
101 101
102 #ifdef VERIFY_HEAP 102 #ifdef VERIFY_HEAP
103 if (FLAG_verify_heap) { 103 if (FLAG_verify_heap) {
104 value->ObjectVerify(); 104 value->ObjectVerify();
105 } 105 }
106 #endif 106 #endif
107 107
108 // Update the pending exception flag and return the value. 108 // Update the pending exception flag and return the value.
109 bool has_exception = value->IsException(); 109 bool has_exception = value->IsException(isolate);
110 DCHECK(has_exception == isolate->has_pending_exception()); 110 DCHECK(has_exception == isolate->has_pending_exception());
111 if (has_exception) { 111 if (has_exception) {
112 isolate->ReportPendingMessages(); 112 isolate->ReportPendingMessages();
113 return MaybeHandle<Object>(); 113 return MaybeHandle<Object>();
114 } else { 114 } else {
115 isolate->clear_pending_message(); 115 isolate->clear_pending_message();
116 } 116 }
117 117
118 return Handle<Object>(value, isolate); 118 return Handle<Object>(value, isolate);
119 } 119 }
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 471
472 isolate_->counters()->stack_interrupts()->Increment(); 472 isolate_->counters()->stack_interrupts()->Increment();
473 isolate_->counters()->runtime_profiler_ticks()->Increment(); 473 isolate_->counters()->runtime_profiler_ticks()->Increment();
474 isolate_->runtime_profiler()->MarkCandidatesForOptimization(); 474 isolate_->runtime_profiler()->MarkCandidatesForOptimization();
475 475
476 return isolate_->heap()->undefined_value(); 476 return isolate_->heap()->undefined_value();
477 } 477 }
478 478
479 } // namespace internal 479 } // namespace internal
480 } // namespace v8 480 } // namespace v8
OLDNEW
« no previous file with comments | « src/elements.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698