Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/core/dom/ContainerNode.h

Issue 2059163002: Schedule sibling invalidation sets for sibling insert/remove. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ContainerNode.h
diff --git a/third_party/WebKit/Source/core/dom/ContainerNode.h b/third_party/WebKit/Source/core/dom/ContainerNode.h
index b85b102ab8e406d0aa0c93e4353049f110bce7f7..c9f1f95f38e0c4a2aa6096fc88d2b674ea24c85b 100644
--- a/third_party/WebKit/Source/core/dom/ContainerNode.h
+++ b/third_party/WebKit/Source/core/dom/ContainerNode.h
@@ -159,7 +159,7 @@ public:
// FIXME: These methods should all be renamed to something better than "check",
// since it's not clear that they alter the style bits of siblings and children.
enum SiblingCheckType { FinishedParsingChildren, SiblingElementInserted, SiblingElementRemoved };
- void checkForSiblingStyleChanges(SiblingCheckType, Node* nodeBeforeChange, Node* nodeAfterChange);
+ void checkForSiblingStyleChanges(SiblingCheckType, Node* changedNode, Node* nodeBeforeChange, Node* nodeAfterChange);
void recalcChildStyle(StyleRecalcChange);
bool childrenSupportStyleSharing() const { return !hasRestyleFlags(); }
@@ -176,6 +176,7 @@ public:
{
ChildrenChange change = {
node.isElementNode() ? ElementInserted : NonElementInserted,
+ &node,
node.previousSibling(),
node.nextSibling(),
byParser
@@ -187,6 +188,7 @@ public:
{
ChildrenChange change = {
node.isElementNode() ? ElementRemoved : NonElementRemoved,
+ &node,
previousSibling,
nextSibling,
byParser
@@ -199,6 +201,7 @@ public:
bool isChildElementChange() const { return type == ElementInserted || type == ElementRemoved; }
ChildrenChangeType type;
+ Member<Node> siblingChanged;
Member<Node> siblingBeforeChange;
Member<Node> siblingAfterChange;
ChildrenChangeSource byParser;

Powered by Google App Engine
This is Rietveld 408576698