Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: components/omnibox/browser/omnibox_controller.h

Issue 2059143002: "up-to-date" should only use hyphens when used as compound modifier of a noun (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_CONTROLLER_H_ 5 #ifndef COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_CONTROLLER_H_
6 #define COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_CONTROLLER_H_ 6 #define COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_CONTROLLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 14 matching lines...) Expand all
25 namespace gfx { 25 namespace gfx {
26 class Rect; 26 class Rect;
27 } 27 }
28 28
29 // This class controls the various services that can modify the content 29 // This class controls the various services that can modify the content
30 // for the omnibox, including AutocompleteController and InstantController. It 30 // for the omnibox, including AutocompleteController and InstantController. It
31 // is responsible of updating the omnibox content. 31 // is responsible of updating the omnibox content.
32 // TODO(beaudoin): Keep on expanding this class so that OmniboxEditModel no 32 // TODO(beaudoin): Keep on expanding this class so that OmniboxEditModel no
33 // longer needs to hold any reference to AutocompleteController. Also make 33 // longer needs to hold any reference to AutocompleteController. Also make
34 // this the point of contact between InstantController and OmniboxEditModel. 34 // this the point of contact between InstantController and OmniboxEditModel.
35 // As the refactor progresses, keep the class comment up-to-date to 35 // As the refactor progresses, keep the class comment up to date to
36 // precisely explain what this class is doing. 36 // precisely explain what this class is doing.
37 class OmniboxController : public AutocompleteControllerDelegate { 37 class OmniboxController : public AutocompleteControllerDelegate {
38 public: 38 public:
39 OmniboxController(OmniboxEditModel* omnibox_edit_model, 39 OmniboxController(OmniboxEditModel* omnibox_edit_model,
40 OmniboxClient* client); 40 OmniboxClient* client);
41 ~OmniboxController() override; 41 ~OmniboxController() override;
42 42
43 // The |current_url| field of input is only set for mobile ports. 43 // The |current_url| field of input is only set for mobile ports.
44 void StartAutocomplete(const AutocompleteInput& input) const; 44 void StartAutocomplete(const AutocompleteInput& input) const;
45 45
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 // but the ones specifically needed are unclear. We should therefore spend 90 // but the ones specifically needed are unclear. We should therefore spend
91 // some time to extract these fields and use a tighter structure here. 91 // some time to extract these fields and use a tighter structure here.
92 AutocompleteMatch current_match_; 92 AutocompleteMatch current_match_;
93 93
94 base::WeakPtrFactory<OmniboxController> weak_ptr_factory_; 94 base::WeakPtrFactory<OmniboxController> weak_ptr_factory_;
95 95
96 DISALLOW_COPY_AND_ASSIGN(OmniboxController); 96 DISALLOW_COPY_AND_ASSIGN(OmniboxController);
97 }; 97 };
98 98
99 #endif // COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_CONTROLLER_H_ 99 #endif // COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_CONTROLLER_H_
OLDNEW
« no previous file with comments | « components/history/core/browser/history_database.h ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698