Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2059093002: Get rid of useless function HitTestResult::spellingToolTip() (Closed)

Created:
4 years, 6 months ago by yosin_UTC9
Modified:
4 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of useless function HitTestResult::spellingToolTip() This patch gets rid of useless function |HitTestResult::spellingToolTip()|, which returns result of grammar checking, since Blink doesn't support grammar checking, to simplify source code for improving code health. BUG=619452 TEST=n/a; no user visible changes Committed: https://crrev.com/ea953678df513eff2c4e128d8849ab05e0031198 Cr-Commit-Position: refs/heads/master@{#399417}

Patch Set 1 : 2016-06-13T14:47:06 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M third_party/WebKit/Source/core/layout/HitTestResult.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.cpp View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
yosin_UTC9
PTAL
4 years, 6 months ago (2016-06-13 06:07:29 UTC) #4
tkent
lgtm
4 years, 6 months ago (2016-06-13 06:12:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059093002/1
4 years, 6 months ago (2016-06-13 06:14:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/162085)
4 years, 6 months ago (2016-06-13 07:09:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059093002/1
4 years, 6 months ago (2016-06-13 08:04:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 08:27:55 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 08:29:26 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea953678df513eff2c4e128d8849ab05e0031198
Cr-Commit-Position: refs/heads/master@{#399417}

Powered by Google App Engine
This is Rietveld 408576698