Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 205903004: WebGL: Return both unprefixed and prefixed supported names from getSupportedExtensions (Closed)

Created:
6 years, 9 months ago by oetuaho-nv
Modified:
6 years, 9 months ago
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

WebGL: Return both unprefixed and prefixed supported names from getSupportedExtensions WebGL spec requires that getExtension "Returns an object if, and only if, name is an ASCII case-insensitive match [HTML] for one of the names returned from getSupportedExtensions; otherwise, returns null." Respect this requirement by always returning both unprefixed and prefixed names from getSupportedExtensions in case they are supported by getExtension. Functionality that is common to both getExtension and getSupportedExtensions is refactored to separate helper functions so that maintaining this becomes easier. BUG=354454 TEST=WebGL conformance tests R=bajones@chromium.org, kbr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170071

Patch Set 1 #

Total comments: 1

Patch Set 2 : Explain meaning of EnabledDraftExtension better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -32 lines) Patch
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.h View 1 6 chunks +10 lines, -11 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 4 chunks +30 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bajones
Non-owner LGTM. This patch feels more complete than the version I submitted (https://crrev.com/200033004/). I'd prefer ...
6 years, 9 months ago (2014-03-21 21:35:11 UTC) #1
oetuaho-nv
On 2014/03/21 21:35:11, bajones wrote: > Non-owner LGTM. > > This patch feels more complete ...
6 years, 9 months ago (2014-03-24 10:09:55 UTC) #2
Ken Russell (switch to Gerrit)
LGTM with one comment adjusted. Let's move toward community approval of the draft extensions currently ...
6 years, 9 months ago (2014-03-25 18:21:11 UTC) #3
oetuaho-nv
The CQ bit was checked by oetuaho@nvidia.com
6 years, 9 months ago (2014-03-26 10:55:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/205903004/40001
6 years, 9 months ago (2014-03-26 10:55:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 12:05:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-26 12:05:12 UTC) #7
bajones
On 2014/03/26 12:05:12, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 9 months ago (2014-03-26 16:08:22 UTC) #8
bajones
Committed patchset #2 manually as r170071 (presubmit successful).
6 years, 9 months ago (2014-03-26 17:52:40 UTC) #9
Ken Russell (switch to Gerrit)
6 years, 9 months ago (2014-03-27 20:30:23 UTC) #10
Message was sent while issue was closed.
On 2014/03/26 16:08:22, bajones wrote:
> On 2014/03/26 12:05:12, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   tryserver.blink on linux_blink_dbg
> 
> I'll land this manually. CQ has been hard to do a clean commit with recently.

Please notify the Chrome troopers about failures like this.

Powered by Google App Engine
This is Rietveld 408576698