Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: chrome/browser/extensions/extension_storage_monitor_browsertest.cc

Issue 2058913002: Disable flaky test ExtensionStorageMonitorTest.UninstallExtension (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 DisableForInstalledExtensions) { 247 DisableForInstalledExtensions) {
248 DisableForInstalledExtensions(); 248 DisableForInstalledExtensions();
249 249
250 const Extension* extension = InitWriteDataApp(); 250 const Extension* extension = InitWriteDataApp();
251 ASSERT_TRUE(extension); 251 ASSERT_TRUE(extension);
252 WriteBytesNotExpectingNotification(extension, GetInitialExtensionThreshold()); 252 WriteBytesNotExpectingNotification(extension, GetInitialExtensionThreshold());
253 } 253 }
254 254
255 // Verify that notifications are disabled when the user clicks the action button 255 // Verify that notifications are disabled when the user clicks the action button
256 // in the notification. 256 // in the notification.
257 IN_PROC_BROWSER_TEST_F(ExtensionStorageMonitorTest, UninstallExtension) { 257 // Flaky: https://crbug.com/617801
258 IN_PROC_BROWSER_TEST_F(ExtensionStorageMonitorTest,
259 DISABLED_UninstallExtension) {
258 const Extension* extension = InitWriteDataApp(); 260 const Extension* extension = InitWriteDataApp();
259 ASSERT_TRUE(extension); 261 ASSERT_TRUE(extension);
260 WriteBytesExpectingNotification(extension, GetInitialExtensionThreshold()); 262 WriteBytesExpectingNotification(extension, GetInitialExtensionThreshold());
261 263
262 // Fake clicking the notification button to uninstall and accepting the 264 // Fake clicking the notification button to uninstall and accepting the
263 // uninstall. 265 // uninstall.
264 ScopedTestDialogAutoConfirm scoped_autoconfirm( 266 ScopedTestDialogAutoConfirm scoped_autoconfirm(
265 ScopedTestDialogAutoConfirm::ACCEPT); 267 ScopedTestDialogAutoConfirm::ACCEPT);
266 TestExtensionRegistryObserver observer(ExtensionRegistry::Get(profile()), 268 TestExtensionRegistryObserver observer(ExtensionRegistry::Get(profile()),
267 extension->id()); 269 extension->id());
268 message_center::MessageCenter::Get()->ClickOnNotificationButton( 270 message_center::MessageCenter::Get()->ClickOnNotificationButton(
269 GetNotificationId(extension->id()), 271 GetNotificationId(extension->id()),
270 ExtensionStorageMonitor::BUTTON_UNINSTALL); 272 ExtensionStorageMonitor::BUTTON_UNINSTALL);
271 observer.WaitForExtensionUninstalled(); 273 observer.WaitForExtensionUninstalled();
272 } 274 }
273 275
274 } // namespace extensions 276 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698