Enable InputDeviceServer/InputDeviceClient in mash.

Enable InputDeviceServer/InputDeviceClient in mash.

Remove the stub version of DeviceDataManager that is created in the
browser and ash processes when running under mash. The stub version
never has any input-device information because the real
DeviceDataManager is in the mus process.

Create InputDeviceClient inside ash and chrome which connects to mus and
receives input-device updates via Mojo IPC.

The mus process starts InputDeviceServer to listen for observers and
update them when new input-device information is available.

BUG=601981
Committed: https://crrev.com/523bf0ebab6ebdafb419e517666f14aa769bd429
Cr-Commit-Position: refs/heads/master@{#400746}

[kylechar, 2016-06-10 19:34:47]

kylechar@chromium.org changed reviewers:
+ ben@chromium.org, sadrul@chromium.org

[kylechar, 2016-06-10 19:34:48]

Adding sadrul@ to check general correctness. Adding ben@ for OWNERS approval
after sadrul@ signs off.

[sadrul, 2016-06-13 15:31:06]

https://codereview.chromium.org/2058853002/diff/20001/ash/sysui/BUILD.gn
File ash/sysui/BUILD.gn (right):

https://codereview.chromium.org/2058853002/diff/20001/ash/sysui/BUILD.gn#newc...
ash/sysui/BUILD.gn:44: "//components/mus/public/interfaces/input_devices",
You shouldn't need to explicitly list this, since cpp/input_devices brings this
in, right?

https://codereview.chromium.org/2058853002/diff/20001/ash/sysui/manifest.json
File ash/sysui/manifest.json (right):

https://codereview.chromium.org/2058853002/diff/20001/ash/sysui/manifest.json...
ash/sysui/manifest.json:19: "interfaces": [
"input_device::mojom::InputDeviceServer" ]
I think it makes sense for mus to automatically expose this to "apps" (see
//components/mus/manifest.json), instead of each app explicitly having to list
this?

[kylechar, 2016-06-13 15:51:10]

https://codereview.chromium.org/2058853002/diff/20001/ash/sysui/BUILD.gn
File ash/sysui/BUILD.gn (right):

https://codereview.chromium.org/2058853002/diff/20001/ash/sysui/BUILD.gn#newc...
ash/sysui/BUILD.gn:44: "//components/mus/public/interfaces/input_devices",
On 2016/06/13 15:31:06, sadrul wrote:
> You shouldn't need to explicitly list this, since cpp/input_devices brings
this
> in, right?

Forgot it was public_dep. Done.

https://codereview.chromium.org/2058853002/diff/20001/ash/sysui/manifest.json
File ash/sysui/manifest.json (right):

https://codereview.chromium.org/2058853002/diff/20001/ash/sysui/manifest.json...
ash/sysui/manifest.json:19: "interfaces": [
"input_device::mojom::InputDeviceServer" ]
That sounds better. Done.

[sadrul, 2016-06-13 16:55:32]

lgtm

[Ben Goodger (Google), 2016-06-15 17:17:47]

lgtm with nit that applies to other cl too

https://codereview.chromium.org/2058853002/diff/40001/components/mus/manifest...
File components/mus/manifest.json (right):

https://codereview.chromium.org/2058853002/diff/40001/components/mus/manifest...
components/mus/manifest.json:10: "input_device::mojom::InputDeviceServer",
actually, is tehre a reason this is in a separate namespace? can you put it in
mus like everything else here?

[kylechar, 2016-06-15 17:21:52]

https://codereview.chromium.org/2058853002/diff/40001/components/mus/manifest...
File components/mus/manifest.json (right):

https://codereview.chromium.org/2058853002/diff/40001/components/mus/manifest...
components/mus/manifest.json:10: "input_device::mojom::InputDeviceServer",
On 2016/06/15 17:17:46, Ben Goodger (Google) wrote:
> actually, is tehre a reason this is in a separate namespace? can you put it in
> mus like everything else here?

Huh. No good reason. The original plan was to make it a component (with a unique
namespace) but now that it's part of mus that doesn't make sense. Will move
everything into namespace mus.

[kylechar, 2016-06-15 19:21:01]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-06-15 19:21:02]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2058853002/#ps60001
(title: "Change namespace.")

[commit-bot: I haz the power, 2016-06-15 19:21:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058853002/60001

[commit-bot: I haz the power, 2016-06-15 19:35:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 19:35:18]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[kylechar, 2016-06-16 12:58:28]

Patchset #5 (id:80001) has been deleted

[kylechar, 2016-06-17 15:42:12]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-06-17 15:42:12]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2058853002/#ps120001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-06-17 15:42:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058853002/120001

[commit-bot: I haz the power, 2016-06-17 17:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 17:15:44]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kylechar, 2016-06-17 18:33:31]

On 2016/06/17 17:15:44, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Turns out no one creates DeviceDataManager on Windows. Will have to handle that
case.

[kylechar, 2016-06-20 13:35:13]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-06-20 13:35:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2058853002/#ps140001
(title: "Check for DDM existence.")

[commit-bot: I haz the power, 2016-06-20 13:35:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058853002/140001

[commit-bot: I haz the power, 2016-06-20 14:46:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 14:46:44]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kylechar, 2016-06-20 18:40:07]

On 2016/06/20 14:46:44, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Looks like a flakey test. Going to try CQ again.

[kylechar, 2016-06-20 18:40:09]

On 2016/06/20 14:46:44, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Looks like a flakey test. Going to try CQ again.

[kylechar, 2016-06-20 18:40:14]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-06-20 18:40:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058853002/140001

[commit-bot: I haz the power, 2016-06-20 19:17:23]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-06-20 19:20:35]

Description was changed from

==========
Enable InputDeviceServer/InputDeviceClient in mash.

Remove the stub version of DeviceDataManager that is created in the
browser and ash processes when running under mash. The stub version
never has any input-device information because the real
DeviceDataManager is in the mus process.

Create InputDeviceClient inside ash and chrome which connects to mus and
receives input-device updates via Mojo IPC.

The mus process starts InputDeviceServer to listen for observers and
update them when new input-device information is available.

BUG=601981
==========

to

==========
Enable InputDeviceServer/InputDeviceClient in mash.

Remove the stub version of DeviceDataManager that is created in the
browser and ash processes when running under mash. The stub version
never has any input-device information because the real
DeviceDataManager is in the mus process.

Create InputDeviceClient inside ash and chrome which connects to mus and
receives input-device updates via Mojo IPC.

The mus process starts InputDeviceServer to listen for observers and
update them when new input-device information is available.

BUG=601981

Committed: https://crrev.com/523bf0ebab6ebdafb419e517666f14aa769bd429
Cr-Commit-Position: refs/heads/master@{#400746}
==========

[commit-bot: I haz the power, 2016-06-20 19:20:36]

Patchset 7 (id:??) landed as
https://crrev.com/523bf0ebab6ebdafb419e517666f14aa769bd429
Cr-Commit-Position: refs/heads/master@{#400746}