third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp - Issue 2058823002: Implement callback reactions for Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp

Issue 2058823002: Implement callback reactions for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stack-ce

Patch Set: dominicc review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.h ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp

index 7198c6f95c469150540a7604075ca7dec524bad1..8da5f43b04b0a562c632977f40902cca1a9dd23c 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.cpp

@@ -4,25 +4,16 @@

#include "core/dom/custom/CustomElementUpgradeReaction.h"

-#include "core/dom/Element.h"

#include "core/dom/custom/CustomElementDefinition.h"

namespace blink {

CustomElementUpgradeReaction::CustomElementUpgradeReaction(

CustomElementDefinition* definition)

- : m_definition(definition)

+ : CustomElementReaction(definition)

{

}

-CustomElementUpgradeReaction::~CustomElementUpgradeReaction() = default;

-DEFINE_TRACE(CustomElementUpgradeReaction)

- CustomElementReaction::trace(visitor);

- visitor->trace(m_definition);

void CustomElementUpgradeReaction::invoke(Element* element)

{

m_definition->upgrade(element);