third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h - Issue 2058823002: Implement callback reactions for Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h

Issue 2058823002: Implement callback reactions for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stack-ce

Patch Set: dominicc review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElementReaction.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeReaction.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h b/third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h

index e98e808ce5cc1d8862416a28e9c2680c1b125045..ae11a347f88b879fe4ed902bb58b8477be258f03 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h

@@ -77,6 +77,7 @@ class TestReaction : public CustomElementReaction {

WTF_MAKE_NONCOPYABLE(TestReaction);

public:

TestReaction(std::initializer_list<Command*> commands)

+ : CustomElementReaction(nullptr)

{

// TODO(dominicc): Simply pass the initializer list when

// HeapVector supports initializer lists like Vector.