Implement callback reactions for Custom Elements V1

third_party/WebKit/Source/core/dom/custom/CustomElement.h

Index: third_party/WebKit/Source/core/dom/custom/CustomElement.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElement.h b/third_party/WebKit/Source/core/dom/custom/CustomElement.h
index b4637109016095e548aa896aefdf71e9aaad1d7d..727e227c424b554c54252436519c9fa0c87a2d96 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElement.h
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElement.h
@@ -18,6 +18,7 @@ class Element;
 class HTMLElement;
 class QualifiedName;
 class CustomElementDefinition;
+class CustomElementReaction;
 class CustomElementRegistry;
 
 class CORE_EXPORT CustomElement {
@@ -29,25 +30,7 @@ public:
     static CustomElementsRegistry* registry(const Element&);
     static CustomElementsRegistry* registry(const Document&);
 
-    // Returns true if element could possibly match a custom element
-    // descriptor *now*. See CustomElementDescriptor::matches for the
-    // meaning of "match". Custom element processing which depends on
-    // matching a descriptor, such as upgrade, can be skipped for
-    // elements that fail this test.
-    //
-    // Although this result is currently constant for a given element,
-    // when customized built-in elements are implemented the result
-    // will depend on the value of the 'is' attribute. In addition,
-    // these elements may stop matching descriptors after being
-    // upgraded, so use Node::getCustomElementState to detect
-    // customized elements.
-    static bool descriptorMayMatch(const Element& element)

[kojii, 2016/06/13 02:31:10]

Should "getCustomElementState() == CustomElementState::Undefined" do this now? I
suspected this is a tentative code until we get getCustomElementState() stable,
but if I miss something, please let me know and I'll revert this change.

[dominicc (has gone to gerrit), 2016/06/13 07:59:01]

Yep, sounds good! We don't need this any more. Yay.

-    {
-        // TODO(dominicc): Broaden this check when customized built-in
-        // elements are implemented.
-        return isValidName(element.localName())
-            && element.namespaceURI() == HTMLNames::xhtmlNamespaceURI;
-    }
+    static CustomElementDefinition* definitionForElement(const Element&);
 
     static bool isValidName(const AtomicString& name);
 
@@ -57,10 +40,14 @@ public:
     static HTMLElement* createCustomElement(Document&, const AtomicString& localName, CreateElementFlags);
     static HTMLElement* createCustomElement(Document&, const QualifiedName&, CreateElementFlags);
 
-    static void enqueueUpgradeReaction(Element*, CustomElementDefinition*);
+    static void enqueueConnectedCallback(Element*);
+    static void enqueueDisconnectedCallback(Element*);
+    static void enqueueAttributeChangedCallback(Element*, const QualifiedName&,
+        const AtomicString& oldValue, const AtomicString& newValue);
 
 private:
     static HTMLElement* createCustomElementAsync(Document&, CustomElementDefinition&, const QualifiedName&);
+

[dominicc (has gone to gerrit), 2016/06/13 07:59:01]

Nit: Delete?

[kojii, 2016/06/13 14:56:42]

This is to be deleted in another CL ;)

 };
 
 } // namespace blink