Implement callback reactions for Custom Elements V1

third_party/WebKit/Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 1406 matching lines @@
         return InsertionDone;
 
     if (hasRareData()) {
         ElementRareData* rareData = elementRareData();
         rareData->clearClassListValueForQuirksMode();
         if (rareData->intersectionObserverData())
             rareData->intersectionObserverData()->activateValidIntersectionObservers(*this);
     }
 
     if (inShadowIncludingDocument()) {
-        if (getCustomElementState() != CustomElementState::Custom && CustomElement::descriptorMayMatch(*this)) {
-            if (CustomElementsRegistry* registry = CustomElement::registry(*this))
-                registry->addCandidate(this);
+        if (getCustomElementState() == CustomElementState::Custom) {
+            CustomElement::enqueueConnectedCallback(this);
+        } else {
+            if (getCustomElementState() == CustomElementState::Undefined) {
+                if (CustomElementsRegistry* registry = CustomElement::registry(*this))
+                    registry->addCandidate(this);
+            }
+            if (isUpgradedV0CustomElement())

[dominicc (has gone to gerrit), 2016/06/13 07:59:01]

Maybe this case should come before if (getCustomElementState() ==
CustomElementState::Undefined) and make that the else branch:

if (getCustomElementState() == CustomElementState::Custom) {
  for upgraded v1 elements
else if (isUpgradedV0CustomElement())
  for upgraded v0 elements
else if (getCustomElementState() == CustomElementState::Undefined)
  v1 processing for un-upgraded elements (v0 does not do anything here)

+                V0CustomElement::didAttach(this, document());
         }
-        if (isUpgradedV0CustomElement())
-            V0CustomElement::didAttach(this, document());
     }
 
     TreeScope& scope = insertionPoint->treeScope();
     if (scope != treeScope())
         return InsertionDone;
 
     const AtomicString& idValue = getIdAttribute();
     if (!idValue.isNull())
         updateId(scope, nullAtom, idValue);
 
@@ skipping 40 matching lines @@
     }
 
     ContainerNode::removedFrom(insertionPoint);
     if (wasInDocument) {
         if (this == document().cssTarget())
             document().setCSSTarget(nullptr);
 
         if (hasPendingResources())
             document().accessSVGExtensions().removeElementFromPendingResources(this);
 
-        if (isUpgradedV0CustomElement())
+        if (getCustomElementState() == CustomElementState::Custom)
+            CustomElement::enqueueDisconnectedCallback(this);
+        else if (isUpgradedV0CustomElement())
             V0CustomElement::didDetach(this, insertionPoint->document());
 
         if (needsStyleInvalidation())
             document().styleEngine().styleInvalidator().clearInvalidation(*this);
     }
 
     document().removeFromTopLayer(this);
 
     clearElementFlag(IsInCanvasSubtree);
 
@@ skipping 1678 matching lines @@
 }
 
 void Element::willModifyAttribute(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& newValue)
 {
     if (name == HTMLNames::nameAttr) {
         updateName(oldValue, newValue);
     }
 
     if (oldValue != newValue) {
         document().styleEngine().attributeChangedForElement(name, *this);
-        if (isUpgradedV0CustomElement())
+        if (getCustomElementState() == CustomElementState::Custom)
+            CustomElement::enqueueAttributeChangedCallback(this, name, oldValue, newValue);
+        else if (isUpgradedV0CustomElement())
             V0CustomElement::attributeDidChange(this, name.localName(), oldValue, newValue);
     }
 
     if (MutationObserverInterestGroup* recipients = MutationObserverInterestGroup::createForAttributesMutation(*this, name))
         recipients->enqueueMutationRecord(MutationRecord::createAttributes(this, name, oldValue));
 
     InspectorInstrumentation::willModifyDOMAttr(this, oldValue, newValue);
 }
 
 void Element::didAddAttribute(const QualifiedName& name, const AtomicString& value)
@@ skipping 514 matching lines @@
 
 DEFINE_TRACE_WRAPPERS(Element)
 {
     if (hasRareData()) {
         visitor->traceWrappers(elementRareData());
     }
     ContainerNode::traceWrappers(visitor);
 }
 
 } // namespace blink