Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2058783002: media: Replace wtf/Assertions.h macros in favor of base/logging.h macros (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
davve
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros Replaced ASSERT with DCHECK in mediasession module. BUG=596522 Committed: https://crrev.com/c3fe6f1821c41ae39804811188937ba6a81e9458 Cr-Commit-Position: refs/heads/master@{#399429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/mediasession/MediaSession.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSessionError.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-10 15:38:58 UTC) #4
davve
lgtm
4 years, 6 months ago (2016-06-13 08:18:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058783002/1
4 years, 6 months ago (2016-06-13 08:18:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 11:11:20 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 11:11:21 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 11:12:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3fe6f1821c41ae39804811188937ba6a81e9458
Cr-Commit-Position: refs/heads/master@{#399429}

Powered by Google App Engine
This is Rietveld 408576698