Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2058763002: Cleanup VulkanWindowContext for use on Android (Closed)

Created:
4 years, 6 months ago by djsollen
Modified:
4 years, 6 months ago
Reviewers:
jvanverth1, liyuqian
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup VulkanWindowContext for use on Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M tools/viewer/Viewer.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/viewer/sk_app/VulkanWindowContext.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/viewer/sk_app/android/VulkanWindowContext_android.cpp View 1 chunk +1 line, -1 line 0 comments Download
A tools/viewer/sk_app/android/WindowContext_android.h View 1 chunk +21 lines, -0 lines 0 comments Download
M tools/viewer/sk_app/android/Window_android.h View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
djsollen
4 years, 6 months ago (2016-06-10 14:27:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058763002/1
4 years, 6 months ago (2016-06-10 14:27:26 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 6 months ago (2016-06-10 14:27:27 UTC) #6
jvanverth1
lgtm
4 years, 6 months ago (2016-06-10 14:29:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058763002/20001
4 years, 6 months ago (2016-06-10 14:38:27 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 14:50:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9207caebbb34a8f239191a2f9f639abf183bf568

Powered by Google App Engine
This is Rietveld 408576698