Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 205873003: Refactor interface dependency resolution (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Refactor interface dependency resolution This refactors simplifies dependency resolution, and makes it easier to extend. Specifically: * Move file handling into idl_reader * Move actual definition and interface merging to methods on IdlDefinitions and IdlInterface (in idl_definitions) This also clarifies exactly what's going on specially: * we tack on some extended attributes to members * we merge implemented interfaces to the main one Other changes: * use next() instead of looping over a one-element list * remove useless exceptions (specific exception classes are only useful if we catch them, otherwise it's no better than a string) This is to support a separate CL: Bindings: inherit enums and callbacks from partial interface files. https://codereview.chromium.org/203193015/ TBR=haraken BUG=345137 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -57 lines) Patch
M Source/bindings/scripts/idl_definitions.py View 2 chunks +22 lines, -0 lines 0 comments Download
M Source/bindings/scripts/idl_reader.py View 1 chunk +26 lines, -5 lines 0 comments Download
M Source/bindings/scripts/interface_dependency_resolver.py View 5 chunks +35 lines, -52 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
A refactoring which will help Mounir; PTAL. (and makes the code rather clearer anyway)
6 years, 9 months ago (2014-03-20 02:05:34 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-20 02:07:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/205873003/1
6 years, 9 months ago (2014-03-20 02:07:31 UTC) #3
commit-bot: I haz the power
Change committed as 169613
6 years, 9 months ago (2014-03-20 04:11:38 UTC) #4
haraken
6 years, 9 months ago (2014-03-20 04:29:48 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698