Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: ui/aura/gestures/gesture_recognizer_unittest.cc

Issue 2058723003: Slop region check for multi-finger scroll (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/gestures/gesture_recognizer_unittest.cc
diff --git a/ui/aura/gestures/gesture_recognizer_unittest.cc b/ui/aura/gestures/gesture_recognizer_unittest.cc
index e7444067477ffe18d418f4d7ecffc95a1f6240bf..e0ec5abe8a1c7e6fd080d117b651dc7841e11351 100644
--- a/ui/aura/gestures/gesture_recognizer_unittest.cc
+++ b/ui/aura/gestures/gesture_recognizer_unittest.cc
@@ -2576,6 +2576,7 @@ TEST_F(GestureRecognizerTest, TwoFingerTap) {
delegate->events(), ui::ET_GESTURE_TAP_CANCEL, ui::ET_GESTURE_BEGIN);
// Little bit of touch move should not affect our state.
+ // Moving within slop region doesn't cause scrolling.
delegate->Reset();
ui::TouchEvent move1(ui::ET_TOUCH_MOVED, gfx::Point(102, 202),
kTouchId1, tes.Now());
@@ -2583,8 +2584,7 @@ TEST_F(GestureRecognizerTest, TwoFingerTap) {
ui::TouchEvent move2(ui::ET_TOUCH_MOVED, gfx::Point(131, 202),
kTouchId2, tes.Now());
DispatchEventUsingWindowDispatcher(&move2);
- EXPECT_3_EVENTS(delegate->events(), ui::ET_GESTURE_SCROLL_BEGIN,
- ui::ET_GESTURE_SCROLL_UPDATE, ui::ET_GESTURE_SCROLL_UPDATE);
+ EXPECT_0_EVENTS(delegate->events());
// Make sure there is enough delay before the touch is released so that it is
// recognized as a tap.
@@ -2597,15 +2597,14 @@ TEST_F(GestureRecognizerTest, TwoFingerTap) {
delegate->events(), ui::ET_GESTURE_TWO_FINGER_TAP, ui::ET_GESTURE_END);
// Lift second finger.
- // Make sure there is enough delay before the touch is released so that it is
- // recognized as a tap.
+ // Two fingers have been down at some point during the current touch,
+ // single tap doesn't happen while releasing the second finger.
delegate->Reset();
ui::TouchEvent release2(ui::ET_TOUCH_RELEASED, gfx::Point(130, 201),
kTouchId2, tes.LeapForward(50));
DispatchEventUsingWindowDispatcher(&release2);
- EXPECT_2_EVENTS(
- delegate->events(), ui::ET_GESTURE_SCROLL_END, ui::ET_GESTURE_END);
+ EXPECT_1_EVENT(delegate->events(), ui::ET_GESTURE_END);
}
TEST_F(GestureRecognizerTest, TwoFingerTapExpired) {
« no previous file with comments | « content/browser/renderer_host/input/stylus_text_selector.cc ('k') | ui/events/gesture_detection/gesture_detector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698