Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2058713002: Update dependency on dart2js to fix parser crash. (Closed)

Created:
4 years, 6 months ago by ahe
Modified:
4 years, 6 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@master
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Update dependency on dart2js to fix parser crash. Fixes #19 BUG=https://github.com/dart-lang/rasta/issues/19 R=kasperl@google.com Committed: https://github.com/dart-lang/rasta/commit/8b6ecb00aa0405dd008499030166b62d900f2d55

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M submodules.txt View 1 chunk +1 line, -1 line 0 comments Download
A + test/kernel/regression/bad_interpolation.dart View 1 chunk +1 line, -2 lines 0 comments Download
A + test/kernel/regression/bad_interpolation.dart.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ahe
4 years, 6 months ago (2016-06-10 10:27:31 UTC) #3
kasperl
LGTM.
4 years, 6 months ago (2016-06-10 10:53:01 UTC) #4
ahe
4 years, 6 months ago (2016-06-10 12:22:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
8b6ecb00aa0405dd008499030166b62d900f2d55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698