Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/common/metrics/proto/omnibox_event.proto

Issue 20587003: InstantExtended: record initial focus state for omnibox interactions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix comments. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/metrics/proto/omnibox_event.proto
diff --git a/chrome/common/metrics/proto/omnibox_event.proto b/chrome/common/metrics/proto/omnibox_event.proto
index c31bdf8c3c2ac59c8a767a96a092ea095c891493..34f37609bd73c99b29628ec39f588dd0236b5a75 100644
--- a/chrome/common/metrics/proto/omnibox_event.proto
+++ b/chrome/common/metrics/proto/omnibox_event.proto
@@ -69,11 +69,17 @@ message OmniboxEventProto {
// Note that if the homepage is set to the new tab page or about blank,
// then we'll classify the web page into those categories, not HOMEPAGE.
OTHER = 4; // everything not included somewhere else on this list
- INSTANT_NEW_TAB_PAGE = 5; // new tab page rendered by Instant
+ OBSOLETE_INSTANT_NEW_TAB_PAGE = 5; // new tab page rendered by Instant
// The user is on a search result page that's doing search term
// replacement, meaning the search terms should've appeared in the omnibox
// before the user started editing it, not the URL of the page.
SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6;
+ // The new tab page in which this omnibox interaction first started
+ // with the user having focus in the omnibox.
+ INSTANT_NEW_TAB_PAGE_WITH_OMNIBOX_AS_STARTING_FOCUS = 7;
+ // The new tab page in which this omnibox interaction first started
+ // with the user having focus in the fakebox.
+ INSTANT_NEW_TAB_PAGE_WITH_FAKEBOX_AS_STARTING_FOCUS = 8;
Ilya Sherman 2013/08/02 21:47:32 Please get the changes to the protocol buffer appr
Mark P 2013/08/02 21:53:24 samarth: I'll do this for you.
Mark P 2013/08/03 00:19:03 This is done. https://cr/50306267 As part of this
samarth 2013/08/06 16:29:25 Done.
}
optional PageClassification current_page_classification = 10;

Powered by Google App Engine
This is Rietveld 408576698