InstantExtended: record initial focus state for omnibox interactions.

chrome/browser/ui/omnibox/omnibox_edit_model.h

Index: chrome/browser/ui/omnibox/omnibox_edit_model.h
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.h b/chrome/browser/ui/omnibox/omnibox_edit_model.h
index 4087b4d307cb5f61bdec6ddf07350be92cbf510d..5cfcc735f627eba81092d002fb94842a63825b1d 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.h
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.h
@@ -50,7 +50,8 @@ class OmniboxEditModel {
           const string16& gray_text,
           const string16& keyword,
           bool is_keyword_hint,
-          OmniboxFocusState focus_state);
+          OmniboxFocusState focus_state,
+          OmniboxFocusState focus_state_for_input);
     ~State();
 
     bool user_input_in_progress;
@@ -59,6 +60,7 @@ class OmniboxEditModel {
     const string16 keyword;
     const bool is_keyword_hint;
     OmniboxFocusState focus_state;
+    OmniboxFocusState focus_state_for_input;
   };
 
   OmniboxEditModel(OmniboxView* view,
@@ -411,6 +413,11 @@ class OmniboxEditModel {
 
   OmniboxFocusState focus_state_;
 
+  // The focus state when the user initiated input in the omnibox. Only a valid
+  // value, OMNIBOX_FOCUS_{VISIBLE,INVISIBLE}, while user input is in progress
+  // and the ommnibox has focus.
+  OmniboxFocusState focus_state_for_input_;

[Peter Kasting, 2013/07/26 23:22:34]

The name of this seems unclear, and the type might need changing too.

Seems like the name should be something more like "initial_focus_source_", and
we want something more like:

enum FocusSource {
  INVALID,
  OMNIBOX,
  FAKEBOX,
};

I suppose we could continue to use OmniboxFocusState for this, but it seems less
clear -- it would at least need commentary.  Or perhaps we should just change
OmniboxFocusState to FocusedOmniboxField or some equivalent, with the values I
list above, which would probably still be equivalently clear everywhere else
(didn't look to see).

[samarth, 2013/07/29 18:55:35]

So when I initially wrote the code around invisible focus, I consciously tried
to keep the precise notion of  a "fakebox" out of the omnibox (and the browser
code in general), and everything here talks about the visibility of the cursor.

So my options are:
(1) Keep this is as-is and just add some more comments.
(2) Change the metrics enum to also say visible/invisible focus.
(3) Change the omnibox code to have FocusedOmniboxField or something.

I have a slight preference for (2).  What about you?

+
   // The URL of the currently displayed page.
   string16 permanent_text_;