InstantExtended: record initial focus state for omnibox interactions.

chrome/browser/metrics/metrics_log.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/metrics_log.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 136 matching lines @@
     case AutocompleteInput::INVALID_SPEC:
       return OmniboxEventProto::INVALID_SPEC;
     case AutocompleteInput::NEW_TAB_PAGE:
       return OmniboxEventProto::NEW_TAB_PAGE;
     case AutocompleteInput::BLANK:
       return OmniboxEventProto::BLANK;
     case AutocompleteInput::HOMEPAGE:
       return OmniboxEventProto::HOMEPAGE;
     case AutocompleteInput::OTHER:
       return OmniboxEventProto::OTHER;
-    case AutocompleteInput::INSTANT_NEW_TAB_PAGE:
-      return OmniboxEventProto::INSTANT_NEW_TAB_PAGE;
+    case AutocompleteInput::OBSOLETE_INSTANT_NEW_TAB_PAGE:
+      return OmniboxEventProto::OBSOLETE_INSTANT_NEW_TAB_PAGE;

[Ilya Sherman, 2013/08/02 21:47:32]

nit: NOTREACHED()?  Maybe you could even remove the enum value on the
AutocompleteInput side?

[Mark P, 2013/08/02 21:53:24]

You realize this suggestion is the exact opposite of the previous code you
suggested and reviewed? :-)
https://codereview.chromium.org/20747002/

[Ilya Sherman, 2013/08/02 22:01:49]

How so?  I'm not recommending adding a default case for this switch stmt.  I'm
recommending removing the enumerated constant
AutocompleteInput::OBSOLETE_INSTANT_NEW_TAB_PAGE, which reduces the number of
cases that we need to handle in this switch stmt... while still preserving the
property that failing to handle new enumerated values would be a compile-time
error.

[Mark P, 2013/08/02 22:08:42]

Oh, yes, I misread your suggestion.  It sounds smart.  Let's do it.

[Mark P, 2013/08/06 17:22:14]

Please take this suggestion from Ilya before you submit.

[samarth, 2013/08/06 17:30:45]

Oops sorry.  Thanks for catching that.  Done.  (I left the field commented-out
in the file to ensure we don't accidentally reuse that value.)

[Mark P, 2013/08/06 17:34:14]

You might as well remove the value from autocomplete_input.  It's not stored
anywhere, and nothing bad will happen if reuse that enum value.  (Obviously,
keep the enum value in the proto file; we need to not reuse that one.)

[samarth, 2013/08/06 17:43:03]

OK, done.

     case AutocompleteInput::SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT:
       return OmniboxEventProto::
           SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT;
+    case AutocompleteInput::INSTANT_NEW_TAB_PAGE_WITH_OMNIBOX_AS_STARTING_FOCUS:
+      return OmniboxEventProto::
+          INSTANT_NEW_TAB_PAGE_WITH_OMNIBOX_AS_STARTING_FOCUS;
+    case AutocompleteInput::INSTANT_NEW_TAB_PAGE_WITH_FAKEBOX_AS_STARTING_FOCUS:
+      return OmniboxEventProto::
+          INSTANT_NEW_TAB_PAGE_WITH_FAKEBOX_AS_STARTING_FOCUS;
   }
   return OmniboxEventProto::INVALID_SPEC;
 }
 
 ProfilerEventProto::TrackedObject::ProcessType AsProtobufProcessType(
     int process_type) {
   switch (process_type) {
     case content::PROCESS_TYPE_BROWSER:
       return ProfilerEventProto::TrackedObject::BROWSER;
     case content::PROCESS_TYPE_RENDERER:
@@ skipping 768 matching lines @@
 
       paired_device->set_vendor_prefix(vendor_prefix);
     }
 
     paired_device->set_vendor_id(device->GetVendorID());
     paired_device->set_product_id(device->GetProductID());
     paired_device->set_device_id(device->GetDeviceID());
   }
 #endif  // defined(OS_CHROMEOS)
 }