Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 2058683002: Sanitize https:// URLs before sending them to PAC scripts. (Closed)

Created:
4 years, 6 months ago by eroman
Modified:
4 years, 6 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Sanitize https:// URLs before sending them to PAC scripts. This additionally strips the path and query components for https:// URL (embedded identity and reference fragment were already being stripped). For debugging purposes this behavior can be disabled with the command line flag --unsafe-pac-url. BUG=593759 R=mmenke@chromium.org Review URL: https://codereview.chromium.org/1996773002 . Cr-Commit-Position: refs/heads/master@{#395266} (cherry picked from commit 81357b39c643fc746517fd6ce5cb2076b7ddc3f4) Committed: https://chromium.googlesource.com/chromium/src/+/564023217f3589aadf636203dcb2b33d58a7d1c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -4 lines) Patch
M chrome/browser/net/proxy_service_factory.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/proxy/proxy_service.h View 4 chunks +27 lines, -0 lines 0 comments Download
M net/proxy/proxy_service.cc View 3 chunks +27 lines, -4 lines 0 comments Download
M net/proxy/proxy_service_unittest.cc View 1 chunk +220 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
eroman
4 years, 6 months ago (2016-06-10 07:22:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
564023217f3589aadf636203dcb2b33d58a7d1c7 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698