Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 205863002: Remove SVGPaintType enum hardcoding (Closed)

Created:
6 years, 9 months ago by rwlbuis
Modified:
6 years, 9 months ago
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove SVGPaintType enum hardcoding We do not have to follow the specified values for SVG2 anymore, so use the default ordering. Later on this could help since the enum could potentially be bitpacked to less bits. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/core/svg/SVGPaint.h View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rwlbuis
PTAL
6 years, 9 months ago (2014-03-20 02:25:05 UTC) #1
rwlbuis
Add more reviewers.
6 years, 9 months ago (2014-03-20 15:46:54 UTC) #2
kouhei (in TOK)
On 2014/03/20 15:46:54, rwlbuis wrote: > Add more reviewers. non-owner lgtm. This is not exposed ...
6 years, 9 months ago (2014-03-20 15:55:23 UTC) #3
pdr.
On 2014/03/20 15:55:23, kouhei wrote: > On 2014/03/20 15:46:54, rwlbuis wrote: > > Add more ...
6 years, 9 months ago (2014-03-20 18:12:19 UTC) #4
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-20 18:12:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/205863002/1
6 years, 9 months ago (2014-03-20 18:12:30 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 20:07:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-20 20:08:00 UTC) #8
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-20 20:27:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/205863002/1
6 years, 9 months ago (2014-03-20 20:27:21 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 21:28:23 UTC) #11
Message was sent while issue was closed.
Change committed as 169695

Powered by Google App Engine
This is Rietveld 408576698